Repository navigation
fix(turbopack): preserve imports used by merged re-exports - #196
Merged
Merged
Conversation
fireairforce
marked this pull request as ready for review
September 24, 2026 11:18
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve generated
__TURBOPACK__imported__module__*binding names during the per-module hygiene pass. When severalexport *modules are concatenated, a re-export getter can still refer to the original import name while that pass renames the declaration. The merged-module hygiene pass can resolve collisions with the declaration and references together.Reproduction
A production Utoopack build of imall-main emitted two
FormListContextgetters referencing an undeclared__TURBOPACK__imported__module__888359__. Importing a namespace from@alipay/tech-uiand reading its exports triggered aReferenceErrorand a white page. The production chunk loaded successfully; this is generated JavaScript, not a public-path failure.Verification
pack-napiwith this change and completed the full imall-main production build using the affected dependency versions.cargo fmtcargo clippy --all-targets -- -D warnings --no-depsThe companion
utooPR adds a snapshot fixture that executes the re-export getter and reproduces the original failure before this fix.Companion regression fixture: utooland/utoo#3393.